fix: resume form should support all known types #819
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Carina Ursu <[email protected]>
ursucarina
requested review from
a team,
FrankFlitton and
jsonporter
and removed request for
a team
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #819 +/- ##
==========================================
- Coverage 63.34% 63.34% -0.01%
==========================================
Files 527 527
Lines 13401 13400 -1
Branches 2555 2554 -1
==========================================
- Hits 8489 8488 -1
Misses 4912 4912
☔ View full report in Codecov by Sentry. |
jsonporter
approved these changes
Oct 9, 2023
FrankFlitton
approved these changes
Oct 9, 2023
|
🎉 This PR is included in version 1.9.7 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Allows relaunch form to deserialize all input types as opposed to just simple
Type
Are all requirements met?